Changeset 6658

Timestamp:

09/02/05 16:11:15 (3 years ago)

Author:

iblech

Message:

* pugs::hack: Extremely minor cosmetic fixes.
* t/statements/for_with_only_one_item.t: Expanded tests based on p6l feedback,

Juerd++, see http://www.nntp.perl.org/group/perl.perl6.language/22971.

* Removed t/operators/binding.t and added t/operators/binding/scalars.t (former

binding.t), t/operators/binding/arrays.t (39 tests), and
t/operators/binding/hashes.t (30 tests).

* PIL2JS: Prelude::JS::Array, Prelude::JS::Hash: Binding of not yet existing

array/hash elements should autovivify (i.e., @array[$out_of_bounds_index] :=
..., %hash<not_existing_key> := ... should work). With these fixes, PIL2JS
passes binding/scalars.t 28/28, arrays.t 36/39, and hashes.t 30/30. :)

Files:

• lib/pugs/hack.pod (modified) (2 diffs)
• perl5/PIL2JS/lib6/Prelude/JS/Array.pm (modified) (1 diff)
• perl5/PIL2JS/lib6/Prelude/JS/Hash.pm (modified) (1 diff)
• t/operators/binding (added)
• t/operators/binding/arrays.t (added)
• t/operators/binding/hashes.t (added)
• t/operators/binding/scalars.t (moved) (moved from t/operators/binding.t) (2 diffs)
• t/statements/for_with_only_one_item.t (modified) (3 diffs)

lib/pugs/hack.pod

@@ -266 +266 @@
 
 Where applicable, conventions documented in Damian Conway's "Perl Best
-Practices" book (Oreilly, 2005) should be followed by default.  At the very
+Practices" book (O'Reilly, 2005) should be followed by default.  At the very
 least, all indenting should be done with spaces (4 per indent level) rather than
 tabs, so the code and documentation looks the same to everyone.
@@ -279 +279 @@
     $ export PERL6LIB=blib6/lib
 
-You can also just say F<./pugs -Iblib6/lib t/.../mumble.t>.
+You can also just say C<./pugs -Iblib6/lib t/.../mumble.t>.
 
 =head3 Regex testing

perl5/PIL2JS/lib6/Prelude/JS/Array.pm

@@ -321 +321 @@
       ret.BINDTO = function (other) {
         if(array[idx] == undefined)
-          PIL2JS.die("Can\'t rebind non-existant array container!");
+          array[idx] = new PIL2JS.Box(undefined);
 
         return array[idx].BINDTO(other);

perl5/PIL2JS/lib6/Prelude/JS/Hash.pm

@@ -73 +73 @@
       ret.BINDTO = function (other) {
         if(!hash.exists(key))
-          PIL2JS.die("Can\'t rebind non-existant hash container!");
+          hash.add_pair(new PIL2JS.Pair(
+            new PIL2JS.Box.ReadOnly(key),
+            new PIL2JS.Box(undefined)
+          ));
 
         return hash.get_value(key).BINDTO(other);

t/operators/binding/scalars.t

@@ -17 +17 @@
 
 # L<S03/"Binding" /replaces the container itself.  For instance:/>
+# Basic scalar binding tests
+{
+  my $x = 'Just Another';
+  is($x, 'Just Another', 'normal assignment works');
 
-my $x = 'Just Another';
-is($x, 'Just Another', 'normal assignment works');
+  my $y := $x;
+  is($y, 'Just Another', 'y is now bound to x');
 
-my $y := $x;
-is($y, 'Just Another', 'y is now bound to x');
+  ok($y =:= $x, 'y is bound to x (we checked with the =:= identity op)');
 
-ok($y =:= $x, 'y is bound to x (we checked with the =:= identity op)');
+  my $z = $x;
+  is($z, 'Just Another', 'z is not bound to x');
 
-my $z = $x;
-is($z, 'Just Another', 'z is not bound to x');
+  ok(!($z =:= $x), 'z is not bound to x (we checked with the =:= identity op)', :todo);
 
-ok(!($z =:= $x), 'z is not bound to x (we checked with the =:= identity op)', :todo);
+  $y = 'Perl Hacker';
+  is($y, 'Perl Hacker', 'y has been changed to "Perl Hacker"');
+  is($x, 'Perl Hacker', 'x has also been changed to "Perl Hacker"');
 
-$y = 'Perl Hacker';
-is($y, 'Perl Hacker', 'y has been changed to "Perl Hacker"');
-is($x, 'Perl Hacker', 'x has also been changed to "Perl Hacker"');
-
-is($z, 'Just Another', 'z is still "Just Another" because it was not bound to x');
-
-sub bar {
-  return $CALLER::a eq $CALLER::b;
+  is($z, 'Just Another', 'z is still "Just Another" because it was not bound to x');
 }
 
-sub foo {
-  my $a = "foo";
-  my $b := $a;
-  return bar(); # && bar2();
+# Binding and $CALLER::
+{
+  sub bar {
+    return $CALLER::a eq $CALLER::b;
+  }
+
+  sub foo {
+    my $a = "foo";
+    my $b := $a;
+    return bar(); # && bar2();
+  }
+
+  ok(foo(), "CALLER resolves bindings in caller's dynamic scope");
 }
-
-ok(foo(), "CALLER resolves bindings in caller's dynamic scope");
 
 # Binding to swap
@@ -112 +117 @@
 }
 
-# := actually takes function parameter list
+# := actually takes subroutine parameter list
 {
   my $a;

t/statements/for_with_only_one_item.t

@@ -6 +6 @@
 # Test primarily aimed at PIL2JS
 
-plan 5;
+plan 8;
 
+# sanity tests
 {
   my $res;
@@ -22 +23 @@
 }
 
+# for with only one item, a constant
 {
   my $res;
@@ -42 +44 @@
   is $res, "a", "for works with \"a_single_constant\"";
 }
+
+# for with only one item, an arrayref
+# See thread "for $arrayref {...}" on p6l started by Ingo Blechschmidt,
+# http://www.nntp.perl.org/group/perl.perl6.language/22970.
+{
+  my $arrayref = [1,2,3];
+
+  my $count;
+  for ($arrayref,) { $count++ }
+
+  is $count, 1, 'for ($arrayref,) {...} executes the loop body only once';
+}
+
+{
+  my $arrayref = [1,2,3];
+
+  my $count;
+  for ($arrayref) { $count++ }
+
+  is $count, 1, 'for ($arrayref) {...} executes the loop body only once';
+}
+
+{
+  my $arrayref = [1,2,3];
+
+  my $count;
+  for $arrayref { $count++ }
+
+  is $count, 1, 'for $arrayref {...} executes the loop body only once';
+}