Changeset 21162

Timestamp:

07/02/08 06:01:18 (3 months ago)

Author:

pmichaud

Message:

Some updates to S29-list.

Location:

t/spec/S29-list

Files:

• grep.t (modified) (3 diffs)
• map.t (modified) (6 diffs)
• reduce.t (modified) (3 diffs)
• sort.t (modified) (3 diffs)

t/spec/S29-list/grep.t

@@ -24 +24 @@
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "adverbial block"
 {
     my @result = @list.grep():{ ($_ % 2) };
@@ -35 +35 @@
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "adverbial block"
 {
     my @result = @list.grep :{ ($_ % 2) };
@@ -46 +46 @@
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "closure as non-final argument"
 {
     my @result = grep { ($_ % 2) }: @list;
-    is(+@result, 5, 'we got a list back'); 
-    is(@result[0], 1, 'got the value we expected'); 
-    is(@result[1], 3, 'got the value we expected'); 
-    is(@result[2], 5, 'got the value we expected'); 
-    is(@result[3], 7, 'got the value we expected'); 
-    is(@result[4], 9, 'got the value we expected'); 
+    is(+@result, 5, 'we got a list back');
+    is(@result[0], 1, 'got the value we expected');
+    is(@result[1], 3, 'got the value we expected');
+    is(@result[2], 5, 'got the value we expected');
+    is(@result[3], 7, 'got the value we expected');
+    is(@result[4], 9, 'got the value we expected');
 }
 
 # .grep shouldn't work on non-arrays
+##  XXX pmichaud, 2008-07-01:
+##    p6l says that .grep should work on non-list values.
 {
   #?pugs 2 todo 'bug'

t/spec/S29-list/map.t

@@ -24 +24 @@
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "adverbial block"
 {
     my @result = @list.map():{ $_ * 2 };
@@ -45 +45 @@
 }
 
-#?rakudo skip "colon invocant syntax"
+#?rakudo skip "closure as non-final argument"
 {
     my @result = map { $_ * 2 }: @list;
@@ -101 +101 @@
 
 # map with n-ary functions
-#?rakudo skip "colon invocant syntax"
+#?rakudo skip "adverbial block"
 {
   is ~(1,2,3,4).map:{ $^a + $^b             }, "3 7", "map() works with 2-ary functions";
@@ -110 +110 @@
 
 # .map shouldn't work on non-arrays
+## XXX pmichaud, 2008-07-01:  .map should work on non-list values
 {
   #?pugs 2 todo 'bug'
   dies_ok { 42.map: { $_ } },    "method form of map should not work on numbers";
   dies_ok { "str".map: { $_ } }, "method form of map should not work on strings";
-  #?rakudo skip "colon invocant syntax"
+  #?rakudo skip "adverbial block"
   is ~(42,).map:{ $_ }, "42",   "method form of map should work on arrays";
 };
@@ -131 +132 @@
 =end pod
 
-#?rakudo skip "colon invocant syntax"
+##  XXX pmichaud, 2008-07-01:   As the test is written below, the
+##    @expected and "map of ..." arguments are arguments of .map(...)
+##    and not of is(...).  See S12:406.
+#?rakudo skip "syntax error in test"
 {
   my @expected = ("foo","bar");
@@ -140 +144 @@
 
 
-#?rakudo skip "no hashes at the moment"
+#?rakudo skip '{} hash composer not implemented'
 {
   my @a = (1, 2, 3); 

t/spec/S29-list/reduce.t

@@ -21 +21 @@
 
   is((reduce { $^a + $^b }, 0, @array), $sum, "basic reduce works (1)");
-#?rakudo 2 skip 'adverbial closure'
+#?rakudo skip 'closure as non-final argument'
   is((reduce { $^a + $^b }: 100, @array), 100 + $sum, "basic reduce works (2)");
+#?rakudo skip 'method fallback to sub unimpl'
   is(({ $^a * $^b }.reduce: 1,2,3,4,5), 120, "basic reduce works (3)");
 }
@@ -35 +36 @@
 
 # .reduce shouldn't work on non-arrays
+##  XXX pmichaud, 2008-07-01:  .reduce should work on non-list values
 {
 #?pugs 2 todo 'bug'
@@ -42 +44 @@
 }
 
-#?rakudo 4 skip 'parsefail'
+#?rakudo 4 skip '{} hash composer not implemented'
 {
   my $hash = {a => {b => {c => 42}}};

t/spec/S29-list/sort.t

@@ -37 +37 @@
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "closure as non-final argument"
 {
     my @a = (2, 45, 6, 1, 3);
@@ -43 +43 @@
 
     my @s = sort { $^a <=> $^b }: @a;
-    is(@s, @e, '... with closure as indirect invocant'); 
+    is(@s, @e, '... with closure as indirect invocant');
 }
 
-#?rakudo skip "adverbial closure"
+#?rakudo skip "method fallback to sub unimpl"
 {
     my @a = (2, 45, 6, 1, 3);
@@ -153 +153 @@
 
 # .sort shouldn't work on non-arrays
-#?rakudo skip 'adverbial closure'
+##  XXX pmichaud, 2008-07-01:  .sort should work on non-list values
+#?rakudo skip 'test errors, adverbial block'
 {
 #?pugs 2 todo 'bug'