Changeset 16453 for util

Timestamp:

05/19/07 03:45:55 (18 months ago)

Author:

Aankhen

Message:

util/smartlinks.pl:
* removed spurious display: block CSS.
* made JS logic a bit more intelligent about replacing the trailing :.
* tweaked the display of line numbers and test results in the snippet labels.

Files:

• util/smartlinks.pl (modified) (5 diffs)

util/smartlinks.pl

@@ -137 +137 @@
   var id = 'smartlink_' + num;
   var div = document.getElementById(id);
-  div.style.display = (div.style.display == 'none') ? 'block' : 'none';
+  div.style.display = (div.style.display == 'none') ? '' : 'none';
   
   var text = this.firstChild;
@@ -190 +190 @@
       }
       
-      link.replaceChild(document.createTextNode(' -'), link.lastChild); // replace ending ":" with " -"
+      var end = link.lastChild;
+      if ((end.nodeType == 3) && (end.nodeValue.search(/:$/) > -1)) {
+        end.nodeValue = end.nodeValue.replace(/:$/, ' -');
+      }
       
       link.href = '#';
@@ -485 +488 @@
     border: 1px solid;
     padding: 0.2em;
-    display: block;
 }
 </style>
@@ -564 +566 @@
     if ($test_result) {
         if ($ok_count == 0 && $failed_count == 0) {
-            $stat = " &nbsp;&mdash; &nbsp;<code>N/A</code>";
+            $stat = " (no results)";
         } else {
-            $stat = " &nbsp;&mdash; &nbsp;<code>$ok_count √, $failed_count ×</code>";
+            $stat = " (<code>$ok_count √, $failed_count ×</code>)";
         }
     } else {
-        $stat = '<code></code>';
+        $stat = '';
     }
 
@@ -575 +577 @@
 
     my $html = <<"_EOC_";
-<p>From $file lines $from ~ $to$stat:<span id="smartlink_skip_${snippet_id}"> <a href="#smartlink_skipto_${snippet_id}">(skip)</a></span></p>
+<p>From $file lines $from&ndash;$to$stat:<span id="smartlink_skip_${snippet_id}"> <a href="#smartlink_skipto_${snippet_id}">(skip)</a></span></p>
 <div id="smartlink_${snippet_id}" class="smartlink_snippet">
 $snippet