Changeset 13763 for src/Pugs/Prim/List.hs

Timestamp:

10/01/06 04:46:04 (2 years ago)

Author:

audreyt

Message:

* Pugs.Prim.List: Make max/min not compare the first element twice.

Files:

• src/Pugs/Prim/List.hs (modified) (3 diffs)

src/Pugs/Prim/List.hs

@@ -64 +64 @@
 
 op1Min :: Val -> Eval Val
-op1Min v = op1MinMax (== False) v
+op1Min v = op1MinMax not v
 
 op1Max :: Val -> Eval Val
-op1Max v = op1MinMax (== True) v
+op1Max v = op1MinMax id v
 
 -- min_or_max is a function which negates truth/falsehood.
@@ -91 +91 @@
     op1MinMax' _ _ [] = return undef
     -- We have to supply our own comparator...
-    op1MinMax' _ Nothing valList = foldM default_compare (head valList) valList
+    op1MinMax' _ Nothing valList = foldM default_compare (head valList) (tail valList)
     -- or use the one of the user
     op1MinMax' min_or_max (Just subVal) valList = do
@@ -106 +106 @@
               --   +1 ==> a > b
               -- We call min_or_max so we can work for both min() and max().
-              return $ if min_or_max (int > (0::VInt)) then a else b) (head valList) valList
+              return $ if min_or_max (int > (0::VInt)) then a else b) (head valList) (tail valList)
     -- This is the default comparision function, which will be used if the user
     -- hasn't specified a own comparision function.